Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix session leak #269

Merged
merged 2 commits into from
Apr 4, 2023
Merged

fix session leak #269

merged 2 commits into from
Apr 4, 2023

Conversation

zjtaozjtw
Copy link
Contributor

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

#268

Description:

How do you solve it?

当new session 后,及时更新当前使用的session引用

Special notes for your reviewer, ex. impact of this fix, design document, etc:

@CLAassistant
Copy link

CLAassistant commented Mar 31, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@wey-gu wey-gu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codecov-commenter
Copy link

codecov-commenter commented Apr 2, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01 🎉

Comparison is base (bf9fe21) 61.26% compared to head (5ac91a7) 61.28%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #269      +/-   ##
==========================================
+ Coverage   61.26%   61.28%   +0.01%     
==========================================
  Files           9        9              
  Lines        2308     2309       +1     
==========================================
+ Hits         1414     1415       +1     
  Misses        749      749              
  Partials      145      145              
Impacted Files Coverage Δ
session_pool.go 60.96% <100.00%> (+0.11%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@HarrisChu
Copy link
Contributor

this pr would simply fix the issue, but we process session in separate functions. (new session, update or push to list)
prefer refactor those functions...
@Aiee WDYT

@HarrisChu
Copy link
Contributor

maybe we would quick fix first, and then enhance these code in future

@Aiee
Copy link
Contributor

Aiee commented Apr 4, 2023

maybe we would quick fix first, and then enhance these code in future

Makes sense to me.

Copy link
Contributor

@Aiee Aiee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Thanks for your contribution.

@Aiee Aiee merged commit 58215e2 into vesoft-inc:master Apr 4, 2023
@Aiee Aiee mentioned this pull request Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants