Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix: fix the field index conflict inside the method Scan of ResultSet #305

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

haoxins
Copy link
Collaborator

@haoxins haoxins commented Jan 18, 2024

This is hotfix because there is a variable overriding of the i :)

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

@CLAassistant
Copy link

CLAassistant commented Jan 18, 2024

CLA assistant check
All committers have signed the CLA.

@haoxins haoxins marked this pull request as ready for review January 18, 2024 18:19
@haoxins
Copy link
Collaborator Author

haoxins commented Jan 18, 2024

cc @Nicole00 @wey-gu
tested in my service and will add more tests in the future

@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (3fe0bb1) 63.37% compared to head (c6c2d6b) 63.37%.

Files Patch % Lines
result_set.go 87.50% 0 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #305   +/-   ##
=======================================
  Coverage   63.37%   63.37%           
=======================================
  Files           9        9           
  Lines        2452     2452           
=======================================
  Hits         1554     1554           
  Misses        768      768           
  Partials      130      130           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@haoxins haoxins changed the title hotfix: fix the field index conflict hotfix: fix the field index conflict inside the method Scan of ResultSet Jan 18, 2024
@haoxins haoxins mentioned this pull request Jan 18, 2024
3 tasks
Copy link
Contributor

@Nicole00 Nicole00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nicole00 Nicole00 merged commit 5554785 into vesoft-inc:master Jan 22, 2024
20 checks passed
@haoxins haoxins deleted the fix-not-exists branch January 22, 2024 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants