Add tests of parsing string to int (#1337)

* Add tests of parsing string to int * Update workflow
vesoft-inc · Aug 22, 2021 · 422c075 · 422c075
1 parent 09fac4d
commit 422c075
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 3 deletions.
diff --git a/.github/workflows/pull_request.yml b/.github/workflows/pull_request.yml
@@ -91,8 +91,11 @@ jobs:
                   -DCMAKE_CXX_COMPILER=$TOOLSET_DIR/bin/g++ \
                   -DCMAKE_C_COMPILER=$TOOLSET_DIR/bin/gcc \
                   -DCMAKE_BUILD_TYPE=Release \
+                  -DNEBULA_COMMON_REPO_TAG=${{ steps.tag.outputs.tag }} \
+                  -DNEBULA_STORAGE_REPO_TAG=${{ steps.tag.outputs.tag }} \
                   -DENABLE_TESTING=on \
                   -DENABLE_BUILD_STORAGE=on \
+                  -DENABLE_MODULE_FORCE_CHECKOUT=off \
                   -B build
               echo "::set-output name=j::10"
               ;;
@@ -102,8 +105,11 @@ jobs:
                   -DCMAKE_CXX_COMPILER=$TOOLSET_DIR/bin/g++ \
                   -DCMAKE_C_COMPILER=$TOOLSET_DIR/bin/gcc \
                   -DCMAKE_BUILD_TYPE=Debug \
+                  -DNEBULA_COMMON_REPO_TAG=${{ steps.tag.outputs.tag }} \
+                  -DNEBULA_STORAGE_REPO_TAG=${{ steps.tag.outputs.tag }} \
                   -DENABLE_TESTING=on \
                   -DENABLE_BUILD_STORAGE=on \
+                  -DENABLE_MODULE_FORCE_CHECKOUT=off \
                   -B build
               echo "::set-output name=j::10"
               ;;
@@ -115,9 +121,12 @@ jobs:
                 -DCMAKE_CXX_COMPILER=$TOOLSET_DIR/bin/clang++ \
                 -DCMAKE_C_COMPILER=$TOOLSET_DIR/bin/clang \
                 -DCMAKE_BUILD_TYPE=RelWithDebInfo \
+                -DNEBULA_COMMON_REPO_TAG=${{ steps.tag.outputs.tag }} \
+                -DNEBULA_STORAGE_REPO_TAG=${{ steps.tag.outputs.tag }} \
                 -DENABLE_ASAN=on \
                 -DENABLE_TESTING=on \
                 -DENABLE_BUILD_STORAGE=on \
+                -DENABLE_MODULE_FORCE_CHECKOUT=off \
                 -B build
             echo "::set-output name=j::6"
             ;;

diff --git a/tests/tck/features/expression/function/TypeConversion.feature b/tests/tck/features/expression/function/TypeConversion.feature
@@ -59,11 +59,12 @@ Feature: TypeConversion Expression
     When executing query:
       """
       YIELD [toInteger(true), toInteger(false), toInteger(1), toInteger(3.14),
-      toInteger("trUe"), toInteger("3.14"), toInteger(null)] AS yield_toInteger
+      toInteger("trUe"), toInteger("3.14"), toInteger(null), toInteger("1e3"),
+      toInteger("1E3"), toInteger("1.5E4")] AS yield_toInteger
       """
     Then the result should be, in any order:
-      | yield_toInteger                           |
-      | [BAD_TYPE, BAD_TYPE, 1, 3, NULL, 3, NULL] |
+      | yield_toInteger                                              |
+      | [BAD_TYPE, BAD_TYPE, 1, 3, NULL, 3, NULL, 1000, 1000, 15000] |
     When executing query:
       """
       UNWIND [true, false, 1, 3.14, "trUe", "3.14", null] AS b