fix: panic send on closed channel in reader pkg #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veezhang
changed the title
yixinglu
reviewed
Nov 18, 2022
pkg/cmd/runner.go
Outdated
| // fix issues/219 | ||
| // May cause base.FILEDONE to send multiple times, so <-statsMgr.DoneCh return, and then program exit. | ||
| // It may lead to incomplete import, or even panic. | ||
| return |
There was a problem hiding this comment.
I'm confused about the purpose of this return. Even though without this return, this function still always exit when it reaches here.
There was a problem hiding this comment.
Yes, I am solving. It's wip.
veezhang
force-pushed
the
master
branch
3 times, most recently
from
12c8581
to
1ef9e5e
Compare
veezhang
changed the title
veezhang
changed the title
veezhang
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: panic send on closed channel in reader pkg
The number of times
statsMgr.StatsCh <- base.NewFileDoneStats(filename)has reached the number of readers,then
<-statsMgr.DoneChreturn, but not all readers have exited.So, it's need to wait for it exit.