Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support get all host address(#489) #491

Merged
merged 8 commits into from
Nov 30, 2022

Conversation

chenzuyibao
Copy link
Contributor

@chenzuyibao chenzuyibao commented Nov 16, 2022

close #489
支持域名解析所有IP地址

@CLAassistant
Copy link

CLAassistant commented Nov 16, 2022

CLA assistant check
All committers have signed the CLA.

@Nicole00
Copy link
Contributor

Hi, thanks for your contribution, could you please sign the CLA first?

@chenzuyibao
Copy link
Contributor Author

chenzuyibao commented Nov 16, 2022 via email

@chenzuyibao
Copy link
Contributor Author

似乎是单测环境不支持语句了?能否帮忙检查下 @Nicole00

@Nicole00
Copy link
Contributor

Nicole00 commented Nov 16, 2022

已经登录了呀

maybe you should re-push your pr after sign cla.

@chenzuyibao
Copy link
Contributor Author

我是否应该提PR到master分支,而不是我们项目使用的版本2.5.1,第一次PR的过程总是问题很多 😁 @Nicole00

@Nicole00
Copy link
Contributor

我是否应该提PR到master分支,而不是我们项目使用的版本2.5.1,第一次PR的过程总是问题很多 😁 @Nicole00

Sorry, I missed the base branch information. Yeah, you should push your nebula-java-489 branch to master.

@Nicole00 Nicole00 changed the base branch from v2.5.1 to master November 16, 2022 06:55
@codecov-commenter
Copy link

Codecov Report

Base: 63.18% // Head: 63.12% // Decreases project coverage by -0.06% ⚠️

Coverage data is based on head (ba7064d) compared to base (f4431aa).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #491      +/-   ##
============================================
- Coverage     63.18%   63.12%   -0.07%     
  Complexity      781      781              
============================================
  Files            71       71              
  Lines          3746     3748       +2     
  Branches        536      537       +1     
============================================
- Hits           2367     2366       -1     
- Misses         1012     1015       +3     
  Partials        367      367              
Impacted Files Coverage Δ
...com/vesoft/nebula/client/graph/net/NebulaPool.java 87.03% <100.00%> (+0.24%) ⬆️
...vesoft/nebula/client/graph/net/SyncConnection.java 50.81% <0.00%> (-1.64%) ⬇️
...va/com/vesoft/nebula/client/graph/SessionPool.java 54.80% <0.00%> (-0.57%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@chenzuyibao chenzuyibao reopened this Nov 16, 2022
@Nicole00
Copy link
Contributor

you should config your email for your github account.
try git config --global user.email "xxx"
And then, git push again.

@wey-gu
Copy link
Contributor

wey-gu commented Nov 16, 2022

It seems that we need two conditions to fulfill:

  1. sign this with your github user https://cla-assistant.io/vesoft-inc/nebula-java?pullRequest=491
  2. ensure commit's auther and email matched the github credential

looks like the email address doesn't match the GitHub user?

@chenzuyibao you could try change comment authors and push force, or if you are not familiar with them, you could create another local branch locally, apply file changes to new branch and commit with the expected author name and email.

commit 415cb0c36ba8cefdf4f3198d10ebb2007d1b6a24 (HEAD -> nebula-java-489, origin/nebula-java-489)
Author: chenzuyibao <chenzuy***@163.com>
Date:   Wed Nov 16 15:57:08 2022 +0800

    fix: for issue #489

commit ba7064dc0c1bda739e8caf9ece5c7d054903236d
Author: chenzuyibao <96044****@qq.com>
Date:   Wed Nov 16 15:10:12 2022 +0800

    Update README.md

commit 724fcd268a350c882df2395ea48f786cfda4603d
Merge: e1861c8 f4431aa
Author: chenzuyibao <96044****@qq.com>
Date:   Wed Nov 16 15:07:05 2022 +0800

    Merge branch 'master' into nebula-java-489

commit e1861c837254c7685e7cb8dd82f3a1c1b2e37c52
Author: chenzuyibao <[email protected]>
Date:   Wed Nov 16 10:14:22 2022 +0800

    fix: for issue #489

@chenzuyibao
Copy link
Contributor Author

呼~,同一个账号,不同邮箱提交导致的,感谢指导!! @Nicole00 @wey-gu

Copy link
Contributor

@Nicole00 Nicole00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nicole00 Nicole00 merged commit 87f167e into vesoft-inc:master Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Host解析应使用getAllByName以获取所有域名解析结果
6 participants