support edit generate service type (#147)

* support edit generate service type * add charts value
vesoft-inc · Aug 29, 2022 · e8e42e2 · e8e42e2
1 parent eb2e483
commit e8e42e2
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 3 deletions.
diff --git a/apis/apps/v1alpha1/nebulacluster_common.go b/apis/apps/v1alpha1/nebulacluster_common.go
@@ -418,8 +418,13 @@ func generateService(c NebulaClusterComponentter) *corev1.Service {
 	if c.IsHeadlessService() {
 		service.Spec.ClusterIP = corev1.ClusterIPNone
 		service.Spec.PublishNotReadyAddresses = true
-	} else if serviceSpec != nil && serviceSpec.ClusterIP != nil {
-		service.Spec.ClusterIP = *serviceSpec.ClusterIP
+	} else if serviceSpec != nil {
+		if serviceSpec.ClusterIP != nil {
+			service.Spec.ClusterIP = *serviceSpec.ClusterIP
+		}
+		if serviceSpec.Type != "" {
+			service.Spec.Type = serviceSpec.Type
+		}
 	}
 
 	return service

diff --git a/charts/nebula-cluster/templates/nebula-cluster.yaml b/charts/nebula-cluster/templates/nebula-cluster.yaml
@@ -14,7 +14,7 @@ spec:
     env: {{ toYaml .Values.nebula.graphd.env | nindent 6 }}
     config: {{ toYaml .Values.nebula.graphd.config | nindent 6 }}
     service:
-      type: NodePort
+      type: {{ .Values.nebula.graphd.serviceType }}
       externalTrafficPolicy: Local
     logVolumeClaim:
       resources:

diff --git a/charts/nebula-cluster/values.yaml b/charts/nebula-cluster/values.yaml
@@ -9,6 +9,7 @@ nebula:
   graphd:
     image: vesoft/nebula-graphd
     replicas: 2
+    serviceType: NodePort
     env: []
     config: {}
     resources: