Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

write logs to std without log PV mounted #180

Merged
merged 1 commit into from
Feb 25, 2023

Conversation

MegaByte875
Copy link
Contributor

@MegaByte875 MegaByte875 commented Feb 24, 2023

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Copy link
Contributor

@wey-gu wey-gu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@@ -42,7 +42,7 @@ const (
AgentInitContainerName = "ng-init-agent"
DefaultAgentPortGRPC = 8888
agentPortNameGRPC = "grpc"
defaultAgentImage = "megabyte875/nebula-agent:latest"
defaultAgentImage = "vesoft/nebula-agent:latest"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why was megabyte875/nebula-agent:latest previously?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a mistake

return c.nc.Spec.Metad.LogVolumeClaim.Resources.DeepCopy()
}

func (c *metadComponent) GetDataStorageResources() (*corev1.ResourceRequirements, error) {
if c.nc.Spec.Metad.DataVolumeClaim == nil {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand that the request is LogVolumeClaim can be nil. But why DataVolumeClaim can be nil too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prevent panic when the DataVolumeClaim does not exist

@MegaByte875 MegaByte875 merged commit e471235 into vesoft-inc:master Feb 25, 2023
@MegaByte875 MegaByte875 deleted the support_logs_to_std branch August 1, 2023 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants