feat: support JupyterLite/Emscripten #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a fix on Thrift python, to enable nebula-python being supported on jupyterlite, a wasm env in browser powered by pyodide. This will enable embed runnable jupyter/python client of nebulagraph in browser or inline of docs/toturials in the future.
Nicole00
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
Description:
This is a fix on Thrift python, to enable nebula-python being supported on jupyterlite, a wasm env in browser powered by pyodide.
This will enable embedding runnable jupyter/python client runtime of nebulagraph in a browser or inline of docs/tutorials in the future.
How do you solve it?
This is an equivalent downstream implementation of my pr on fbthrift.
Just to inspect the sys platform and when it's on WASM(with Emscripten), just don't lock as it was done for Windows.
Note
This change has to be applied again every time thrift gen was triggered.