This repository has been archived by the owner on Dec 1, 2022. It is now read-only.
restore update atomic operation #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panda-sheep
requested review from
bright-starry-sky,
dutor,
critical27,
darionyaphet and
liuyu85cn
panda-sheep
force-pushed
the
fix_update_atomic_operation
branch
from
5e0d633
to
3dc0da9
Compare
jude-zhu
pushed a commit
to jude-zhu/nebula-storage
that referenced
this pull request
Apr 12, 2021
(cherry picked from commit 253338d)
jude-zhu
added a commit
to jude-zhu/nebula-storage
that referenced
this pull request
Apr 12, 2021
bright-starry-sky
pushed a commit
that referenced
this pull request
Apr 12, 2021
* check type of index (#426) * check type of index * delete get (cherry picked from commit ba7af28) * Specify nebula common branch when checkout (#422) Co-authored-by: dutor <[email protected]> Co-authored-by: CBS <[email protected]> (cherry picked from commit af0bcc4) * fix update atomic operation (#428) (cherry picked from commit 253338d) * #428 * remove extra space Co-authored-by: jimingquan <[email protected]> Co-authored-by: Yee <[email protected]> Co-authored-by: panda-sheep <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update is read-modify-write, which is an atomic operation.
pr #355 change update operation into a non-atomic operation.
The result of the current update is unstable.
According to the logic before this modification, the following case:
Then the two clients are executed separately
The second update statement may be executed successfully or failed.
The expectations are:
The execution of the second update statement failed.