fix: fix issues #355
Merged
fix: fix issues #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huaxiabuluo
reviewed
Nov 15, 2022
app/stores/console.ts
Outdated
| @@ -10,7 +10,7 @@ export const splitQuery = (query: string) => { | |||
| const { gqlList, paramList } = acc; | |||
| const line = cur.trim(); | |||
| if(line.startsWith(':')) { | |||
| paramList.push(line); | |||
| paramList.push(line.replace(/;?$/gm, '')); | |||
Comment on lines
153
to
154
| isSErr := isSessionError(err) | ||
| if isSErr { |
There was a problem hiding this comment.
isSErr seems strange, better to make it one line
if isSessionError(err) {}
nebula-bots
pushed a commit
that referenced
this pull request
Nov 29, 2022
* fix: issues * mod: code review
hetao92
added a commit
that referenced
this pull request
Nov 29, 2022
* fix: issues * mod: code review Co-authored-by: Nut He <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #350
fix the problem that the import task log is messed up
fix parameter in console