Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix issues #369

Merged
merged 1 commit into from
Nov 29, 2022
Merged

fix: fix issues #369

merged 1 commit into from
Nov 29, 2022

Conversation

hetao92
Copy link
Contributor

@hetao92 hetao92 commented Nov 25, 2022

fix:

  • fix get snapshot error when space name has special characters
  • add error message when get schema snapshot failed

mod: code review
Comment on lines +706 to -717
const item = data[i];
if(item.code !== 0) {
err = item.message;
break;
} else {
const edgeList = item.data?.tables || [];
edgeList.forEach(item => {
const { dstID, srcID, edgeName } = item._edgesParsedList[0];
vids.add(srcID);
vids.add(dstID);
edges.push({
src: srcID,
dst: dstID,
name: edgeName,
properties: this.edgeList.find(i => i.name === edgeName).fields.map(field => ({
name: field.Field,
type: field.Type,
}))
});
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unnecessary else

Copy link
Contributor

@huaxiabuluo huaxiabuluo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants