Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Modify the console page graph display(enhancement) #718

Closed
wants to merge 1 commit into from

Conversation

shubihu
Copy link

@shubihu shubihu commented Dec 26, 2023

Modify the console page to run the ngql query statement. If there is a graph, the graph will be displayed by default, as well as the background color of the graph. In addition, the displayed full-screen icon has been moved to the header of the outbox.

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number: #312

Description:

Originally, the table was displayed by default, the graph background was a little gray, and making the full-screen icon difficult to spot.

How do you solve it?

Modify the console page to run the ngql query statement. If there is a graph, the graph will be displayed by default, as well as the background color(#F9FCFF) of the graph. In addition, the displayed full-screen icon has been moved to the header of the outbox.

Special notes for your reviewer, ex. impact of this fix, design document, etc:

image

…re is a graph, the graph will be displayed by default, as well as the background color of the graph. In addition, the displayed full-screen icon has been moved to the header of the outbox.
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


wangjiabin seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@shubihu shubihu changed the title feat: Modify the console page to run the ngql query statement. If the… feat: Modify the console page graph display(enhancement) Dec 26, 2023
@yyh0808
Copy link
Contributor

yyh0808 commented Dec 27, 2023

You have done a great job of thinking! Thank you very much for your suggestions.

Here, I would like to explain the reason for the design. I still suggest placing the enlarged window in the bottom right corner because according to the original plan, we also have a function to expand the window that needs to be placed in the same position.

Regarding the idea of changing the order of tables and graphs, after many discussions, at least some people want to directly see the code execution results instead of visualization because developers' primary work is business development.

So for now, we don't plan on merging your code. However, you made excellent suggestions and I received your desire for customization. We will discuss ways to provide more flexible layouts for these features to meet different developers' habits.

截屏2023-12-27 11 49 45

@yyh0808 yyh0808 closed this Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants