Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revise the usage of CHECK_EQ. Replace them with DCHECK_EQ if DCHECK is sufficient. #4971

Closed
xtcyclist opened this issue Dec 2, 2022 · 1 comment
Closed

Revise the usage of CHECK_EQ. Replace them with DCHECK_EQ if DCHECK is sufficient. #4971

xtcyclist opened this issue Dec 2, 2022 · 1 comment
Assignees
@xtcyclist
Labels
type/enhancement Type: make the code neat or more efficient

Comments

@xtcyclist
Copy link
Contributor

xtcyclist commented Dec 2, 2022 •
edited
Loading

RT.

CHECK_EQ and CHECK may crash the process in the relase mode. Need to check and revise their usages.
@xtcyclist xtcyclist added the type/enhancement Type: make the code neat or more efficient label Dec 2, 2022
@xtcyclist xtcyclist self-assigned this Dec 2, 2022
@xtcyclist xtcyclist mentioned this issue Dec 2, 2022
Closed
11 tasks
@wey-gu wey-gu mentioned this issue Dec 3, 2022
Closed
@xtcyclist xtcyclist mentioned this issue Dec 6, 2022
Closed
11 tasks
@xtcyclist
Copy link
Contributor Author

Haven't found crash bugs cuased by this issue. Close it to avoid too many changes in the code base.

@wey-gu wey-gu mentioned this issue Dec 31, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xtcyclist xtcyclist

Labels
type/enhancement Type: make the code neat or more efficient
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@xtcyclist