support clean last invalid balance plan #2414
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
critical27
requested review from
darionyaphet,
dangleptr,
liuyu85cn,
bright-starry-sky and
panda-sheep
Codecov Report
@@ Coverage Diff @@
## master #2414 +/- ##
==========================================
- Coverage 86.46% 86.25% -0.22%
==========================================
Files 649 648 -1
Lines 64374 66537 +2163
==========================================
+ Hits 55662 57392 +1730
- Misses 8712 9145 +433
Continue to review full report at Codecov.
|
|
|
codesigner
pushed a commit
to codesigner/nebula
that referenced
this pull request
Mar 30, 2023
* change leftjoin to hashleftjoin * fix ctest error * fix test error * add pushfilterdownhashleftjoin rule * add test case * add more test case * fix test error * delete leftjoin * report error when val is not vertex in cypher Co-authored-by: jimingquan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
balance data reset planSUCCEEDED. And we onlyrecoverFAILED task, not the INVALID ones. The behavior is a bit weird.recover. A stopped plan will be marked asFAILEDas well (if it has remaining tasks).Will support in 2.0 later.