Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cascading deletion and addition parts distribution #3059

Merged
merged 3 commits into from
Oct 18, 2021
Merged

Cascading deletion and addition parts distribution #3059

merged 3 commits into from
Oct 18, 2021

Conversation

darionyaphet
Copy link
Contributor 

(root@nebula) [(none)]> create space s5(replica_factor=3, vid_type=int, partition_num=8) on g1
Execution succeeded (time spent 3403/4046 us)

Thu, 14 Oct 2021 07:48:38 CST

(root@nebula) [(none)]> use s5
Execution succeeded (time spent 2116/2825 us)

Thu, 14 Oct 2021 07:48:40 CST

(root@nebula) [s5]> BALANCE DATA
+------------+
| ID         |
+------------+
| 1634168932 |
+------------+
Got 1 rows (time spent 11227/12058 us)

Thu, 14 Oct 2021 07:48:45 CST

(root@nebula) [s5]> BALANCE DATA 1634168932
+----------------------------------------------------------------+-------------+
| balanceId, spaceId:partId, src->dst                            | status      |
+----------------------------------------------------------------+-------------+
| "[1634168932, 34:1, 192.168.8.215:55570->192.168.8.215:55530]" | "SUCCEEDED" |
+----------------------------------------------------------------+-------------+
| "[1634168932, 34:4, 192.168.8.215:55570->192.168.8.215:55530]" | "SUCCEEDED" |
+----------------------------------------------------------------+-------------+
| "[1634168932, 34:6, 192.168.8.215:55550->192.168.8.215:55520]" | "SUCCEEDED" |
+----------------------------------------------------------------+-------------+
| "Total:3, Succeeded:3, Failed:0, In Progress:0, Invalid:0"     | 100.0       |
+----------------------------------------------------------------+-------------+
Got 4 rows (time spent 2130/3089 us)

Thu, 14 Oct 2021 07:48:48 CST

(root@nebula) [s5]> show hosts
+-----------------+-------+----------+--------------+----------------------+------------------------+
| Host            | Port  | Status   | Leader count | Leader distribution  | Partition distribution |
+-----------------+-------+----------+--------------+----------------------+------------------------+
| "192.168.8.215" | 55560 | "ONLINE" | 3            | "s5:3"               | "s5:5"                 |
+-----------------+-------+----------+--------------+----------------------+------------------------+
| "192.168.8.215" | 55570 | "ONLINE" | 1            | "s5:1"               | "s5:3"                 |
+-----------------+-------+----------+--------------+----------------------+------------------------+
| "192.168.8.215" | 55580 | "ONLINE" | 0            | "No valid partition" | "No valid partition"   |
+-----------------+-------+----------+--------------+----------------------+------------------------+
| "192.168.8.215" | 55590 | "ONLINE" | 0            | "No valid partition" | "No valid partition"   |
+-----------------+-------+----------+--------------+----------------------+------------------------+
| "192.168.8.215" | 55510 | "ONLINE" | 1            | "s5:1"               | "s5:2"                 |
+-----------------+-------+----------+--------------+----------------------+------------------------+
| "192.168.8.215" | 55520 | "ONLINE" | 1            | "s5:1"               | "s5:3"                 |
+-----------------+-------+----------+--------------+----------------------+------------------------+
| "192.168.8.215" | 55530 | "ONLINE" | 0            | "No valid partition" | "s5:3"                 |
+-----------------+-------+----------+--------------+----------------------+------------------------+
| "192.168.8.215" | 55540 | "ONLINE" | 1            | "s5:1"               | "s5:4"                 |
+-----------------+-------+----------+--------------+----------------------+------------------------+
| "192.168.8.215" | 55550 | "ONLINE" | 1            | "s5:1"               | "s5:4"                 |
+-----------------+-------+----------+--------------+----------------------+------------------------+
| "Total"         |       |          | 8            | "s5:8"               | "s5:24"                |
+-----------------+-------+----------+--------------+----------------------+------------------------+
Got 10 rows (time spent 3552/5236 us)

Thu, 14 Oct 2021 07:49:06 CST

(root@nebula) [s5]> show parts
+--------------+-----------------------+-----------------------------------------------------------------+-------+
| Partition ID | Leader                | Peers                                                           | Losts |
+--------------+-----------------------+-----------------------------------------------------------------+-------+
| 1            | "192.168.8.215:55560" | "192.168.8.215:55560, 192.168.8.215:55550, 192.168.8.215:55530" | ""    |
+--------------+-----------------------+-----------------------------------------------------------------+-------+
| 2            | "192.168.8.215:55510" | "192.168.8.215:55560, 192.168.8.215:55510, 192.168.8.215:55540" | ""    |
+--------------+-----------------------+-----------------------------------------------------------------+-------+
| 3            | "192.168.8.215:55520" | "192.168.8.215:55570, 192.168.8.215:55550, 192.168.8.215:55520" | ""    |
+--------------+-----------------------+-----------------------------------------------------------------+-------+
| 4            | "192.168.8.215:55540" | "192.168.8.215:55560, 192.168.8.215:55540, 192.168.8.215:55530" | ""    |
+--------------+-----------------------+-----------------------------------------------------------------+-------+
| 5            | "192.168.8.215:55550" | "192.168.8.215:55550, 192.168.8.215:55530, 192.168.8.215:55540" | ""    |
+--------------+-----------------------+-----------------------------------------------------------------+-------+
| 6            | "192.168.8.215:55560" | "192.168.8.215:55560, 192.168.8.215:55570, 192.168.8.215:55520" | ""    |
+--------------+-----------------------+-----------------------------------------------------------------+-------+
| 7            | "192.168.8.215:55560" | "192.168.8.215:55560, 192.168.8.215:55510, 192.168.8.215:55540" | ""    |
+--------------+-----------------------+-----------------------------------------------------------------+-------+
| 8            | "192.168.8.215:55570" | "192.168.8.215:55570, 192.168.8.215:55550, 192.168.8.215:55520" | ""    |
+--------------+-----------------------+-----------------------------------------------------------------+-------+
Got 8 rows (time spent 3123/4446 us)

Thu, 14 Oct 2021 07:50:01 CST

@darionyaphet darionyaphet mentioned this pull request Oct 14, 2021
Closed
@Sophie-Xie Sophie-Xie added the cherry-pick-v2.6 PR: need cherry-pick to this version label Oct 14, 2021
@Sophie-Xie Sophie-Xie added this to the v2.6.0 milestone Oct 14, 2021
@Sophie-Xie Sophie-Xie linked an issue Oct 14, 2021 that may be closed by this pull request
balance data with zone, 2 part peers in the same zone #3029
Closed
@darionyaphet darionyaphet added the ready-for-testing PR: ready for the CI test label Oct 14, 2021
yixinglu
yixinglu reviewed Oct 14, 2021
View reviewed changes
src/meta/processors/admin/Balancer.cpp Outdated Show resolved Hide resolved
src/meta/processors/admin/Balancer.cpp Outdated Show resolved Hide resolved
critical27
critical27 previously approved these changes Oct 15, 2021
View reviewed changes
Copy link
Contributor

@critical27 critical27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Talked offline LGTM

@critical27 critical27 merged commit d0fb27a into vesoft-inc:master Oct 18, 2021
Sophie-Xie pushed a commit that referenced this pull request Oct 18, 2021
@darionyaphet @critical27 @Sophie-Xie
cascading deletion and addition (#3059)
0b763c8 
Co-authored-by: Doodle <[email protected]>
CPWstatic pushed a commit that referenced this pull request Oct 19, 2021
@Sophie-Xie @yixinglu
@critical27 @liuyu85cn @darionyaphet @czpmango @jievince
Cherry pick v2.6.0 1018 (#3136)
650776b 
* Pass graph profile param into storage and cleanup graph storage client interfaces (#3026)

* Cleanup graph storage client interfaces

* Fix compile

* Format

* Fix shadow compile error

* Fix storage core when exit (#3050)

* although I don't have time to check why it works, but this do fix the issue

* fix ut

* Accumulate toss bug fix during test. (#3091)

* add some debug info

* accumulate bug fix for TOSS

Co-authored-by: Doodle <[email protected]>

* Support more validation when create space on an empty zone (#3065)

Co-authored-by: Yee <[email protected]>
Co-authored-by: Doodle <[email protected]>

* small tck fix (#3087)

Co-authored-by: jie.wang <[email protected]>

* cascading deletion and addition (#3059)

Co-authored-by: Doodle <[email protected]>

* fix toss switch not set properly (#3119)

Co-authored-by: Yee <[email protected]>
Co-authored-by: Doodle <[email protected]>

Co-authored-by: Yee <[email protected]>
Co-authored-by: Doodle <[email protected]>
Co-authored-by: [email protected] <[email protected]>
Co-authored-by: yaphet <[email protected]>
Co-authored-by: kyle.cao <[email protected]>
Co-authored-by: jie.wang <[email protected]>
@Sophie-Xie Sophie-Xie mentioned this pull request Oct 19, 2021
Closed
@jamieliu1023 jamieliu1023 mentioned this pull request Oct 20, 2021
Closed
@jamieliu1023 jamieliu1023 mentioned this pull request Nov 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yixinglu yixinglu yixinglu approved these changes

@critical27 critical27 critical27 approved these changes

@bright-starry-sky bright-starry-sky Awaiting requested review from bright-starry-sky

@HarrisChu HarrisChu Awaiting requested review from HarrisChu

@liuyu85cn liuyu85cn Awaiting requested review from liuyu85cn

@panda-sheep panda-sheep Awaiting requested review from panda-sheep

Assignees
No one assigned
Labels
cherry-pick-v2.6 PR: need cherry-pick to this version ready-for-testing PR: ready for the CI test
Projects
None yet
Milestone
v2.6.0
Development

Successfully merging this pull request may close these issues.

balance data with zone, 2 part peers in the same zone
4 participants
@darionyaphet @yixinglu @critical27 @Sophie-Xie