Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Minor] Fix typos in the template #3234

Merged
merged 4 commits into from
Nov 3, 2021
Merged

[Minor] Fix typos in the template #3234

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b80971e
Fix typos in the template
Aiee Oct 29, 2021
916ecee
Fix grammar
Aiee Oct 29, 2021
c847982
Add PR type
Aiee Oct 29, 2021
e93f1be
Address comments
Aiee Oct 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/ISSUE_TEMPLATE/bug-report.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,18 +11,18 @@ assignees: ''

Please check the [FAQ](https://github.com/vesoft-inc/nebula/blob/master/docs/manual-EN/1.overview/2.quick-start/2.FAQ.md) documentation and old issues before raising an issue in case someone has asked the same question that you are asking.

**Describe the bug (__must be provided__)**
**Describe the bug (__required__)**

A clear and concise description of what the bug is.

**Your Environments (__must be provided__)**
**Your Environments (__required__)**

* OS: `uname -a`
* Compliler: `g++ --version` or `clang++ --version`
* Compiler: `g++ --version` or `clang++ --version`
* CPU: `lscpu`
* Commit id (e.g. `a3ffc7d8`)

**How To Reproduce(__must be provided__)**
**How To Reproduce(__required__)**

Steps to reproduce the behavior:

Expand Down
18 changes: 8 additions & 10 deletions .github/pull_request_template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
#### What type of PR is this?
- [ ] bug
- [ ] feature
- [ ] enhancement

#### Which issue(s) this PR fixes:
close #xxx
（If it is requirement, issue(s) number must be listed.）
#### What does this PR do?

#### What this PR does / why we need it?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this PR do? Why we need it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't delete Why we need it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's redundant.


#### Which issue(s)/PR(s) this PR relates to?


#### Special notes for your reviewer, ex. impact of this fix, etc:
Expand All @@ -16,12 +16,10 @@ close #xxx


#### Checklist：
- [ ] Documentation affected （If need to modify document, please label it.)
- [ ] Incompatible （If it is incompatile, please describle it and label it.）
- [ ] Need to cherry pick （If need to cherry pick to some branchs, please label the destination version(s).)
- [ ] Performance regression: Consumes more CPU
- [ ] Performance regression: Consumes more Memory

- [ ] Documentation affected （Please add the label if documentation needs to be modified.)
- [ ] Incompatible （If it is incompatible, please describe it and add corresponding label.）
- [ ] Need to cherry-pick （If need to cherry-pick to some branches, please label the destination version(s).)
- [ ] Performance impacted: Consumes more CPU/Memory


#### Release notes：
Expand Down