Add key value separation feature to Nebula storage engine #3281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenhaocs
requested review from
critical27,
yixinglu,
bright-starry-sky,
darionyaphet,
panda-sheep and
pengweisong
Codecov Report
@@ Coverage Diff @@
## master #3281 +/- ##
==========================================
+ Coverage 85.24% 85.26% +0.02%
==========================================
Files 1289 1289
Lines 120035 120113 +78
==========================================
+ Hits 102322 102414 +92
+ Misses 17713 17699 -14
Continue to review full report at Codecov.
|
| # Whether or not to enable BlobDB (RocksDB key-value separation support) | ||
| --rocksdb_enable_kv_separation=false | ||
| # RocksDB key value separation threshold. Values at or above this threshold will be written to blob files during flush or compaction. | ||
| --rocksdb_kv_separation_threshold=0 |
There was a problem hiding this comment.
if the threshold is set to zero, any writing will move to the blob file?
cooper-lzy
requested review from
cooper-lzy
and removed request for
bright-starry-sky
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes the key-value separation support of RocksDB in Nebula. Based on the experiment with internal dataset and testing environment, we can reduce query latency as much as 80%.