Condition memory checks on cgroup version. #3419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jievince
previously approved these changes
Dec 7, 2021
|
Sure! Formatted the code. |
yixinglu
approved these changes
Dec 7, 2021
Codecov Report
@@ Coverage Diff @@
## master #3419 +/- ##
==========================================
+ Coverage 85.23% 85.28% +0.04%
==========================================
Files 1277 1278 +1
Lines 119088 119198 +110
==========================================
+ Hits 101502 101655 +153
+ Misses 17586 17543 -43
Continue to review full report at Codecov.
|
jievince
approved these changes
Dec 8, 2021
Aiee
approved these changes
Dec 8, 2021
|
@Sophie-Xie please kindly cherry-pick this PR to 2.6.x & 3.x |
Sophie-Xie
pushed a commit
that referenced
this pull request
Jan 24, 2022
* Condition memory checks on cgroup version. * Fix formatting.
critical27
pushed a commit
that referenced
this pull request
Jan 25, 2022
* Condition memory checks on cgroup version. * Fix formatting. Co-authored-by: Igor Rekun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do?
Fixes reading memory stats under cgroup v2.
Which issue(s)/PR(s) this PR relates to?
#3278
Special notes for your reviewer, ex. impact of this fix, etc:
memory.max return 'max' as string when no --memory flag provided to container on startup.
What should I do about it?
Additional context:
Checklist：
Release notes：
Please confirm whether to reflect in release notes and how to describe: