Add constraints on invalid password attempts #3573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aiee
added
ready-for-testing
Aiee
changed the title
yixinglu
reviewed
Dec 28, 2021
Aiee
force-pushed
the
login_attempts
branch
4 times, most recently
from
97b9677
to
d7f7080
Compare
Aiee
added
cherry-pick-v3.0
jievince
reviewed
Dec 29, 2021
HarrisChu
reviewed
Dec 30, 2021
HarrisChu
reviewed
Dec 30, 2021
HarrisChu
reviewed
Dec 30, 2021
HarrisChu
reviewed
Dec 30, 2021
jievince
reviewed
Dec 30, 2021
Comment on lines
146
to
151
| using UserPasswordMap = std::unordered_map<std::string, std::string>; | ||
| // Mapping of user name and remaining wrong password attempts | ||
| using UserPasswordAttemptsRemain = std::unordered_map<std::string, uint32>; | ||
| // Mapping of user name and the timestamp when the account is locked | ||
| using UserLoginLockTime = std::unordered_map<std::string, uint32>; | ||
|
|
There was a problem hiding this comment.
Could these 3 map be merged to one map?
eg.
std::unordered_map<std::string, PassInfo>.
There was a problem hiding this comment.
I've considered this, but UserPasswordMap is used in the localThreadCache as a read-only object, and the rest two objects require both read and write. I believe we could keep it like this for now.
jievince
approved these changes
Dec 30, 2021
HarrisChu
approved these changes
Dec 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do?
Which issue(s)/PR(s) this PR relates to?
Close #2442
Special notes for your reviewer, ex. impact of this fix, etc:
Introducing 2 new gflags:
failed_login_attemptshow many consecutive incorrect passwords input to a SINGLE graph service node cause the account to become locked.
Please note that this flag is functioning on a SINGLE graph node, for example, if there are 3 graph nodes and each node has a
failed_login_attemptsset to 3, this allows a user to input an invalid password for a total of 9 times (3 times per node).password_lock_time_in_secshow long to lock the account after too many consecutive login attempts provide an incorrect password
By default, both glags have a value of 0, which means there is no limitation on login attempts.
For now, these configs function on all users rather than bound to a specific user.
Additional context/ Design document:
Checklist:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: