Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments for planner. #3895

Merged
merged 9 commits into from
Mar 15, 2022
Merged

Conversation

CPWstatic
Copy link
Contributor

@CPWstatic CPWstatic commented Feb 15, 2022

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Just comments.

@Sophie-Xie Sophie-Xie mentioned this pull request Feb 16, 2022
10 tasks
jievince
jievince previously approved these changes Feb 17, 2022
src/graph/planner/match/ArgumentFinder.h Outdated Show resolved Hide resolved
src/graph/planner/match/MatchPlanner.h Outdated Show resolved Hide resolved
src/graph/planner/match/OrderByClausePlanner.h Outdated Show resolved Hide resolved
src/graph/planner/match/PropIndexSeek.h Outdated Show resolved Hide resolved
src/graph/planner/match/ReturnClausePlanner.h Outdated Show resolved Hide resolved
src/graph/planner/match/ScanSeek.h Outdated Show resolved Hide resolved
Comment on lines 93 to 95
// extract vid and edge's prop from GN
// for joinDst & joinInput
// output colNames {srcProps, edgeProps, kVid, "JOIN_DST_VID"}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please capitalize the first character and change the verb to third person singular form.
Ref: https://google.github.io/styleguide/cppguide.html#Function_Comments

@Sophie-Xie Sophie-Xie added ready-for-testing PR: ready for the CI test ready for review labels Feb 25, 2022
yixinglu
yixinglu previously approved these changes Mar 2, 2022
src/graph/planner/plan/Query.h Outdated Show resolved Hide resolved
src/graph/planner/Planner.h Outdated Show resolved Hide resolved
src/graph/planner/Planner.h Outdated Show resolved Hide resolved
src/graph/planner/Planner.h Outdated Show resolved Hide resolved
src/graph/planner/Planner.h Outdated Show resolved Hide resolved
src/graph/planner/match/ArgumentFinder.h Outdated Show resolved Hide resolved
src/graph/planner/match/StartVidFinder.h Outdated Show resolved Hide resolved
src/graph/planner/match/StartVidFinder.h Outdated Show resolved Hide resolved
src/graph/planner/match/StartVidFinder.h Outdated Show resolved Hide resolved
src/graph/planner/plan/Query.h Outdated Show resolved Hide resolved
src/graph/planner/ngql/GoPlanner.cpp Outdated Show resolved Hide resolved
@Aiee Aiee requested a review from jievince March 10, 2022 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants