add optimizer comments #3910
Merged
add optimizer comments #3910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aiee
reviewed
Feb 17, 2022
| * 1. reduce the copy of memory between nodes | ||
| * 2. reduces expression overhead in some cases(similar to column pruning) | ||
| */ | ||
| /* |
There was a problem hiding this comment.
Any reference?
Google style?
There was a problem hiding this comment.
Google style doesn't declare that the comments should use //, but it suggests that the comments style should be unified. I think it makes sense. And the most open source projects i had ever seen use the //. For now i have seen much styles in our project, it's too ugly.
//
/*
*/
/**
*
*/
czpmango
force-pushed
the
opt-comments
branch
from
6cb22de
to
3b13e8b
Compare
yixinglu
previously approved these changes
Mar 2, 2022
czpmango
force-pushed
the
opt-comments
branch
2 times, most recently
from
b642e5e
to
3f47693
Compare
czpmango
requested review from
CPWstatic,
Aiee,
yixinglu,
Shylock-Hg and
jievince
jievince
reviewed
Mar 14, 2022
| bool changed_{true}; | ||
| graph::QueryContext *qctx_{nullptr}; | ||
| // Memo memory management in the Optimizer phase |
jievince
approved these changes
Mar 14, 2022
Aiee
reviewed
Mar 14, 2022
Comment on lines
+39
to
+51
| // +--------+--------+ | ||
| // | Limit | | ||
| // | (limit=3) | | ||
| // +--------+--------+ | ||
| // | | ||
| // +---------+---------+ | ||
| // | AppendVertices | | ||
| // +---------+---------+ | ||
| // | | ||
| // +---------+---------+ | ||
| // | ScanVertices | | ||
| // | (limit=3) | | ||
| // +---------+---------+ |
There was a problem hiding this comment.
Will there still be a limit node after optimization?
Shylock-Hg
reviewed
Mar 15, 2022
| bool changed_{true}; | ||
| graph::QueryContext *qctx_{nullptr}; | ||
| // Memo memory management in the Optimizer phase |
yixinglu
approved these changes
Mar 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Checklist:
Tests:
Affects:
Release notes: