add executor comment #4033
Merged
add executor comment #4033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nevermore3
added
do not review
nevermore3
force-pushed
the
add_comment
branch
2 times, most recently
from
3f74015
to
6d49941
Compare
|
Will you modify log in this PR? |
yes |
nevermore3
force-pushed
the
add_comment
branch
7 times, most recently
from
b52586b
to
4e7e116
Compare
nevermore3
force-pushed
the
add_comment
branch
2 times, most recently
from
179d980
to
186c457
Compare
src/graph/executor/Executor.cpp
Outdated
| * | ||
| * This source code is licensed under Apache 2.0 License. | ||
| */ | ||
| // Copyright (c) 2022 vesoft inc. All rights reserved. |
There was a problem hiding this comment.
maybe should not update the year info. It represent the file create time and maybe make reader confuse.
nevermore3
added
ready-for-testing
nevermore3
force-pushed
the
add_comment
branch
3 times, most recently
from
5ca1e70
to
aa39fc7
Compare
Shylock-Hg
reviewed
Mar 30, 2022
| @@ -99,7 +96,7 @@ StatusOr<DataSet> SubmitJobExecutor::buildResult(meta::cpp2::JobOp jobOp, | |||
| } | |||
| // no default so the compiler will warning when lack | |||
| } | |||
| DLOG(FATAL) << "Unknown job operation " << static_cast<int>(jobOp); | |||
darionyaphet
approved these changes
Mar 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
Description:
How do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Checklist:
Tests:
Affects:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: