Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add parser notes #4064

Merged
merged 4 commits into from
Mar 25, 2022
Merged

add parser notes #4064

merged 4 commits into from
Mar 25, 2022

Conversation

jievince
Copy link
Contributor

Subtask of #3677

@jievince jievince added the ready-for-testing PR: ready for the CI test label Mar 22, 2022
Shylock-Hg
Shylock-Hg reviewed Mar 22, 2022
View reviewed changes
src/parser/parser.yy Outdated Show resolved Hide resolved
@Sophie-Xie Sophie-Xie added this to the v3.1.0 milestone Mar 22, 2022
Shylock-Hg
Shylock-Hg reviewed Mar 23, 2022
View reviewed changes
src/parser/scanner.lex Show resolved Hide resolved
src/parser/scanner.lex Show resolved Hide resolved
@jievince jievince requested a review from CPWstatic March 23, 2022 10:19
@Sophie-Xie Sophie-Xie merged commit 53ada44 into vesoft-inc:master Mar 25, 2022
@jamieliu1023 jamieliu1023 mentioned this pull request Mar 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yixinglu yixinglu yixinglu approved these changes

@CPWstatic CPWstatic CPWstatic approved these changes

@Aiee Aiee Aiee approved these changes

@Shylock-Hg Shylock-Hg Shylock-Hg approved these changes

@dutor dutor Awaiting requested review from dutor dutor is a code owner

@czpmango czpmango Awaiting requested review from czpmango

Assignees
No one assigned
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.
6 participants
@jievince @yixinglu @CPWstatic @Aiee @Shylock-Hg @Sophie-Xie