Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release with separate debug info in ELF format #4400

Merged

Conversation

dutor
Copy link
Contributor

@dutor dutor commented Jul 12, 2022

No description provided.

@dutor dutor added the ready-for-testing PR: ready for the CI test label Jul 12, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #4400 (e00be05) into master (1de182c) will increase coverage by 0.08%.
The diff coverage is 69.76%.

@@            Coverage Diff             @@
##           master    #4400      +/-   ##
==========================================
+ Coverage   84.52%   84.60%   +0.08%     
==========================================
  Files        1345     1345              
  Lines      134014   134022       +8     
==========================================
+ Hits       113272   113394     +122     
+ Misses      20742    20628     -114     
Impacted Files Coverage Δ
src/daemons/GraphDaemon.cpp 60.22% <ø> (+0.44%) ⬆️
src/graph/executor/admin/SpaceExecutor.cpp 76.92% <0.00%> (ø)
src/common/meta/GflagsManager.cpp 73.91% <50.00%> (-1.09%) ⬇️
src/storage/StorageServer.cpp 79.81% <50.00%> (-0.56%) ⬇️
src/graph/service/GraphService.cpp 73.58% <66.66%> (-0.14%) ⬇️
src/kvstore/wal/AtomicLogBuffer.cpp 96.15% <66.66%> (-1.53%) ⬇️
src/kvstore/raftex/RaftPart.cpp 71.53% <88.23%> (+1.53%) ⬆️
src/clients/meta/MetaClient.cpp 76.49% <100.00%> (+0.20%) ⬆️
src/common/time/TimezoneInfo.h 86.95% <100.00%> (+0.59%) ⬆️
src/graph/context/Result.cpp 70.00% <0.00%> (-7.78%) ⬇️
... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a7ab68...e00be05. Read the comment docs.

@Sophie-Xie Sophie-Xie merged commit 68bcf37 into vesoft-inc:master Jul 12, 2022
@dutor dutor deleted the release-with-separate-debug-info branch July 12, 2022 07:28
@Sophie-Xie Sophie-Xie added the cherry-pick-v3.2 PR: need cherry-pick to this version label Jul 13, 2022
critical27 pushed a commit that referenced this pull request Jul 13, 2022
* Fix web service crash(issue:#4398) (#4405)

* when we use flags put interface, but we does not specify the body.
* The service will be crashed.
For example:
curl -X PUT xxx.xxx.xxx.xxxx:19559/flags

* Fix delete vertex or edge, the storage crashed.(#4397) (#4406)

* When our space has tag index or edge index.
* When delete vertex or edge, we specify one vid more than our defined
  in space.
* The sotrage will be crashed.

Solution:
1. Add vid valid verfication.

Co-authored-by: Sophie <[email protected]>

* Release with separate debug info in ELF format (#4400)

Co-authored-by: Milittle <[email protected]>
Co-authored-by: dutor <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-v3.2 PR: need cherry-pick to this version ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants