refactor recover job #4515
Merged
refactor recover job #4515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liwenhui-soul
force-pushed
the
recover
branch
4 times, most recently
from
7fcb687
to
552b729
Compare
SuperYoko
reviewed
Aug 23, 2022
SuperYoko
reviewed
Aug 23, 2022
Codecov Report
@@ Coverage Diff @@
## master #4515 +/- ##
==========================================
+ Coverage 84.66% 84.69% +0.03%
==========================================
Files 1357 1357
Lines 135081 135160 +79
==========================================
+ Hits 114360 114475 +115
+ Misses 20721 20685 -36
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
SuperYoko
approved these changes
Aug 23, 2022
panda-sheep
approved these changes
Aug 24, 2022
critical27
reviewed
Aug 24, 2022
| if (optJob.getStatus() == cpp2::JobStatus::RUNNING && je->isMetaJob()) { | ||
| jds.emplace_back(optJob); | ||
| jds.emplace_back(std::move(optJob)); |
There was a problem hiding this comment.
Will this would break the rule below?
for a balance job:
(1) if there's a newer finished balance job, the stopped or failed balance job can't be recovered.
(2) only the lasted stopped or failed balance job could be recovered
There was a problem hiding this comment.
the guarantee is at jobmanager.cpp:832
| } | ||
| } | ||
| } | ||
| for (auto& jd : jds) { | ||
| jd.setStatus(cpp2::JobStatus::QUEUE, true); | ||
| jd.setStatus(cpp2::JobStatus::FAILED, true); |
There was a problem hiding this comment.
Why you prefer FAILED instead of QUEUED?
There was a problem hiding this comment.
this is the rule 1
|
checked ent-3.3.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
Description:
How do you solve it?
a meta job that used to be RUNNING would be set to FAILED when process restart
only jobs that are failed or stopped could be recovered
all recovered jobs would be set to QUEUE
for a balance job:
(1) if there's a newer finished balance job, the stopped or failed balance job can't be recovered.
(2) only the lasted stopped or failed balance job could be recovered
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Checklist:
Tests:
Affects:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: