Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace spinlock with sharedmutex #4577

Merged
merged 2 commits into from
Aug 24, 2022

Conversation

pengweisong
Copy link
Contributor

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

#4264

Description:

As said in RWSpinLock

You most likely do not want to use RWSpinLock or any other
kind of spinlock. Use SharedMutex instead.

In short, spinlocks in preemptive multi-tasking operating systems
have serious problems and fast mutexes like SharedMutex are almost
certainly the better choice

SpinLock have serious problems in heavy contention situation.

How do you solve it?

Replace them with SharedMutex

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@pengweisong pengweisong added the ready-for-testing PR: ready for the CI test label Aug 23, 2022
@Sophie-Xie Sophie-Xie merged commit 747e318 into vesoft-inc:master Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants