fix issue 4274 #4627
Merged
fix issue 4274 #4627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cangfengzhs
requested review from
jievince,
panda-sheep,
pengweisong and
SuperYoko
and removed request for
jievince
jievince
approved these changes
Sep 8, 2022
SuperYoko
approved these changes
Sep 8, 2022
|
Close #4274 |
critical27
reviewed
Sep 8, 2022
| @@ -1063,7 +1063,6 @@ void RaftPart::processAppendLogResponses(const AppendLogResponses& resps, | |||
| */ | |||
| auto [code, lastCommitId, lastCommitTerm] = commitLogs(std::move(walIt), true, true); | |||
| if (code == nebula::cpp2::ErrorCode::SUCCEEDED) { | |||
| stats::StatsManager::addValue(kCommitLogLatencyUs, execTime_); | |||
There was a problem hiding this comment.
Could add the kCommitLogLatencyUs in the scope from line 1054 to 1082?
There was a problem hiding this comment.
There are two places that will call commitlogs, so if you only add it to the place you said, then the commit latency will record less data. If you add it to both places, then the meaning of this metric will be unclear
There was a problem hiding this comment.
How about add it in commitLogs itself, that could be unified.
There was a problem hiding this comment.
In this PR, it is modified in this way
panda-sheep
approved these changes
Sep 9, 2022
| SCOPED_TIMER(&execTime_); | ||
| SCOPED_TIMER([](uint64_t elapsedTime) { | ||
| stats::StatsManager::addValue(kCommitLogLatencyUs, elapsedTime); | ||
| }); |
critical27
approved these changes
Sep 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
Description:
How do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Checklist:
Tests:
Affects:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: