Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

abandon uppercase letters in fulltext index name #4628

Merged
merged 2 commits into from
Sep 15, 2022

Conversation

cangfengzhs
Copy link
Contributor

@cangfengzhs cangfengzhs commented Sep 7, 2022

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

abandon uppercase letters in fulltext index name

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@cangfengzhs cangfengzhs added the ready-for-testing PR: ready for the CI test label Sep 7, 2022
@cangfengzhs cangfengzhs changed the title abandon uppercase letters in fulltext name abandon uppercase letters in fulltext index name Sep 7, 2022
@Shylock-Hg
Copy link
Contributor

Why add this?

@codecov-commenter
Copy link

codecov-commenter commented Sep 8, 2022

Codecov Report

Base: 84.72% // Head: 84.70% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (1971aa5) compared to base (a7a0185).
Patch coverage: 33.33% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4628      +/-   ##
==========================================
- Coverage   84.72%   84.70%   -0.02%     
==========================================
  Files        1358     1358              
  Lines      135642   135651       +9     
==========================================
- Hits       114926   114908      -18     
- Misses      20716    20743      +27     
Impacted Files Coverage Δ
src/graph/validator/MaintainValidator.cpp 74.77% <0.00%> (-0.86%) ⬇️
src/kvstore/raftex/RaftPart.h 100.00% <ø> (+6.89%) ⬆️
src/storage/admin/AdminProcessor.h 0.00% <ø> (ø)
src/kvstore/Part.cpp 53.55% <50.00%> (ø)
src/kvstore/raftex/RaftPart.cpp 70.11% <100.00%> (-1.08%) ⬇️
src/meta/processors/parts/GetSpaceProcessor.cpp 61.29% <0.00%> (-19.36%) ⬇️
src/storage/exec/IndexNode.cpp 91.66% <0.00%> (-8.34%) ⬇️
src/storage/exec/FilterNode.h 89.47% <0.00%> (-5.27%) ⬇️
...eta/processors/session/SessionManagerProcessor.cpp 73.54% <0.00%> (-4.52%) ⬇️
src/kvstore/raftex/Host.cpp 71.70% <0.00%> (-4.51%) ⬇️
... and 37 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cangfengzhs
Copy link
Contributor Author

Why add this?

You can refer to the associated issue. ES does not allow index to contain uppercase letters.

@critical27 critical27 merged commit 9c745d5 into vesoft-inc:master Sep 15, 2022
@Sophie-Xie Sophie-Xie added the doc affected PR: improvements or additions to documentation label Oct 20, 2022
@foesa-yang foesa-yang self-assigned this Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc affected PR: improvements or additions to documentation ready for review ready-for-testing PR: ready for the CI test
Projects
None yet
6 participants