-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize for the last step of go n steps plan #4690
Conversation
Codecov ReportBase: 84.69% // Head: 84.72% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #4690 +/- ##
==========================================
+ Coverage 84.69% 84.72% +0.03%
==========================================
Files 1358 1358
Lines 135674 135833 +159
==========================================
+ Hits 114911 115091 +180
+ Misses 20763 20742 -21
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Can we do it in optimizer? |
It's very hard to do it in the optimizer. |
// Optimize for some simple go sentence which only need dst id. | ||
// eg. GO 1 TO N STEPS FROM "A" OVER like YIELD DISTINCT like._dst |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These comments are hijacked.
0a91715
to
e3a80d5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
* optimize for the last step of go n steps plan * improve some comments
* optimize for the last step of go n steps plan (#4690) * optimize for the last step of go n steps plan * improve some comments * change time point calculate in ttl (#4683) * change time point calculate in ttl * fix ttl test * enlarge the ttl sleep interval in the test * fix ttl in index * Revert "enlarge the ttl sleep interval in the test" This reverts commit e37bf51. * change wall time in mock data Co-authored-by: Sophie <[email protected]> * fix graph crash (#4698) * fix_ambiguous_case (#4701) * fix_ambiguous_case * change in any order to in order' * fix map hash method (#4707) Co-authored-by: jie.wang <[email protected]> Co-authored-by: pengwei.song <[email protected]> Co-authored-by: jimingquan <[email protected]>
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
Description:
Optimize the last step of go n steps plan.
In the following query, the where clause only uses dst tag props, so we still can replace the last
Getneightbors
withGetDstbySrc
.How do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Checklist:
Tests:
Affects:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: