Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix job status when all finished #4717

Merged
merged 3 commits into from
Oct 13, 2022
Merged

fix job status when all finished #4717

merged 3 commits into from
Oct 13, 2022

Conversation

SuperYoko
Copy link
Contributor

@SuperYoko SuperYoko commented Oct 12, 2022 •
edited
Loading

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

https://github.com/vesoft-inc/nebula-ent/issues/1367

Description:

  1. job name should be data_balance
    removed:
    2. job should be finished when all task is done and no error

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.）
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@SuperYoko SuperYoko added the ready-for-testing PR: ready for the CI test label Oct 12, 2022
@panda-sheep
Copy link
Contributor

panda-sheep commented Oct 12, 2022 •
edited
Loading

@SuperYoko I think vesoft-inc/nebula-ent in issue#1367
the job status should be always in the stop status.
Because when the job is stopped, all the tasks of the job are running. But it's not over.
Finally, all the tasks of the job are completed. The job is still in the stop state, which is more reasonable.

@SuperYoko
Copy link
Contributor Author

SuperYoko commented Oct 12, 2022 •
edited
Loading

Because when the job is stopped, all the tasks of the job are running. But it's not over.

It's truly annoying... Maybe add check that you can't stop a job all tasks are dispatched?

@panda-sheep
Copy link
Contributor

Because when the job is stopped, all the tasks of the job are running. But it's not over.

It's truly annoying... Maybe add check that you can't stop a job all tasks are dispatched?

The job is stopped, and the status of the tasks of the job can be ignored.

@panda-sheep
Copy link
Contributor

Because when the job is stopped, all the tasks of the job are running. But it's not over.

It's truly annoying... Maybe add check that you can't stop a job all tasks are dispatched?

This is the definition of product behavior.

@SuperYoko
Copy link
Contributor Author

Because when the job is stopped, all the tasks of the job are running. But it's not over.

It's truly annoying... Maybe add check that you can't stop a job all tasks are dispatched?

The job is stopped, and the status of the tasks of the job can be ignored.

Make sense... @jinyingsunny what do you think? If you're okay with it, I'll only change this Job name.

@critical27
Copy link
Contributor

Wait a moment

@critical27 critical27 merged commit f7d42ae into vesoft-inc:master Oct 13, 2022
@Sophie-Xie Sophie-Xie added the cherry-pick-v3.3 PR: need cherry-pick to this version label Oct 13, 2022
Sophie-Xie pushed a commit that referenced this pull request Oct 13, 2022
@SuperYoko @Sophie-Xie
fix job status when all finished (#4717)
0e713eb 
* fix job name from zone balance to data balance

* address wenhui's comment
Sophie-Xie added a commit that referenced this pull request Oct 13, 2022
@Sophie-Xie @critical27
@SuperYoko @czpmango
Cherry pick 3.3.0 (10.13) (#4720)
8d63052 
* Use vertex key only when use_vertex_key is on (#4716)

* Revert "insert vertex key when only vertex and flag is set (#4685)"

This reverts commit fff82a6.

* Revert "only write vertex key when flag is set or explictly insert vertex (#4680)"

This reverts commit a5bed33.

* Revert "fix bug (#4675)"

This reverts commit cccc014.

* Revert "Rollback vertex key (#4629)"

This reverts commit 545137a.

* wtf

* tck format

* fix job status when all finished (#4717)

* fix job name from zone balance to data balance

* address wenhui's comment

* fix create index if not exists behavior (#4705)

Co-authored-by: Sophie <[email protected]>
Co-authored-by: Doodle <[email protected]>

Co-authored-by: Doodle <[email protected]>
Co-authored-by: Alex Xing <[email protected]>
Co-authored-by: kyle.cao <[email protected]>
@wey-gu wey-gu mentioned this pull request Oct 15, 2022
Closed
@SuperYoko SuperYoko deleted the fix_balance_job branch March 28, 2023 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liwenhui-soul liwenhui-soul liwenhui-soul approved these changes

@panda-sheep panda-sheep panda-sheep approved these changes

@critical27 critical27 Awaiting requested review from critical27

@pengweisong pengweisong Awaiting requested review from pengweisong

Assignees
No one assigned
Labels
cherry-pick-v3.3 PR: need cherry-pick to this version ready-for-testing PR: ready for the CI test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SuperYoko @panda-sheep @critical27 @liwenhui-soul @Sophie-Xie