Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile storage GetDstBySrcProcessor #4887

Merged
merged 2 commits into from
Nov 17, 2022
Merged

Profile storage GetDstBySrcProcessor #4887

merged 2 commits into from
Nov 17, 2022

Conversation

yixinglu
Copy link
Contributor

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

Replace std::vector with std::deque to improve the memory allocation.

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@yixinglu yixinglu added ready-for-testing PR: ready for the CI test type/enhancement Type: make the code neat or more efficient labels Nov 16, 2022
Copy link
Contributor

@critical27 critical27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll do some optimization in GetDstBySrc later. The dedup is quite slow even with multi thread. Need to check FLAGS_concurrent_dedup_threshold to see whether it really dedup in multi thread.

@Sophie-Xie Sophie-Xie merged commit aaa0431 into master Nov 17, 2022
@Sophie-Xie Sophie-Xie deleted the profile-get-dst branch November 17, 2022 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test type/enhancement Type: make the code neat or more efficient
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants