Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the dependency of argument plan node #4939

Merged
merged 7 commits into from
Nov 28, 2022

Conversation

yixinglu
Copy link
Contributor

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

fix #4938

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@yixinglu yixinglu added the ready-for-testing PR: ready for the CI test label Nov 26, 2022
@codecov-commenter
Copy link

Codecov Report

Base: 76.76% // Head: 76.84% // Increases project coverage by +0.08% 🎉

Coverage data is based on head (e668191) compared to base (8842efb).
Patch coverage: 66.66% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4939      +/-   ##
==========================================
+ Coverage   76.76%   76.84%   +0.08%     
==========================================
  Files        1101     1101              
  Lines       81180    81182       +2     
==========================================
+ Hits        62317    62385      +68     
+ Misses      18863    18797      -66     
Impacted Files Coverage Δ
src/graph/executor/logic/ArgumentExecutor.cpp 86.36% <40.00%> (-8.64%) ⬇️
src/graph/planner/match/MatchPathPlanner.cpp 99.50% <100.00%> (+0.97%) ⬆️
src/graph/planner/plan/Logic.cpp 29.82% <100.00%> (ø)
src/meta/processors/parts/GetSpaceProcessor.cpp 61.29% <0.00%> (-19.36%) ⬇️
src/graph/planner/match/StartVidFinder.cpp 87.50% <0.00%> (-5.84%) ⬇️
src/graph/planner/Planner.cpp 75.00% <0.00%> (-5.00%) ⬇️
src/common/expression/LogicalExpression.cpp 91.89% <0.00%> (-1.69%) ⬇️
src/graph/service/PermissionCheck.cpp 79.59% <0.00%> (-1.66%) ⬇️
src/kvstore/RocksEngine.h 83.09% <0.00%> (-1.41%) ⬇️
src/common/process/ProcessUtils.cpp 84.70% <0.00%> (-1.18%) ⬇️
... and 26 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Sophie-Xie Sophie-Xie merged commit 852512b into vesoft-inc:master Nov 28, 2022
@yixinglu yixinglu deleted the fix-argument-dep branch December 19, 2022 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Argument plan node does not depend on the right start node when explaining the query
5 participants