Fix graphd's crash due to lack of support of xor. #4952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yixinglu
approved these changes
Nov 29, 2022
Codecov ReportBase: 76.84% // Head: 76.86% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #4952 +/- ##
==========================================
+ Coverage 76.84% 76.86% +0.02%
==========================================
Files 1101 1101
Lines 81180 81225 +45
==========================================
+ Hits 62379 62435 +56
+ Misses 18801 18790 -11
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
czpmango
reviewed
Nov 30, 2022
| } else if (expr->kind() == Expression::Kind::kLogicalXor) { | ||
| pullXors(expr); | ||
| } else { | ||
| LOG(FATAL) << "Invalid logical expression kind: " << static_cast<uint8_t>(expr->kind()); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
Close #4951
Description:
Lack of support for xor.
How do you solve it?
Added some methods for xor.
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Checklist:
Tests:
Affects:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: