Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add new es client #4970

Merged
merged 6 commits into from
Dec 2, 2022
Merged

add new es client #4970

merged 6 commits into from
Dec 2, 2022

Conversation

cangfengzhs
Copy link
Contributor

@cangfengzhs cangfengzhs commented Dec 1, 2022 •
edited
Loading

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.）
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@cangfengzhs cangfengzhs added the ready-for-testing PR: ready for the CI test label Dec 1, 2022
panda-sheep
panda-sheep approved these changes Dec 2, 2022
View reviewed changes
Copy link
Contributor

@panda-sheep panda-sheep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

critical27
critical27 reviewed Dec 2, 2022
View reviewed changes
Copy link
Contributor

@critical27 critical27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job

src/common/plugin/fulltext/elasticsearch/ESAdapter.cpp
ESClient& ESAdapter::randomClient() {
static thread_local std::default_random_engine engine;
static thread_local std::uniform_int_distribution<size_t> d(0, clients_.size() - 1);
return clients_[d(engine)];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't quite remember, do we already support sign in multiple es client?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not verify it, but it is supported in grammar and implementation.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@critical27 critical27 merged commit 9058610 into vesoft-inc:master Dec 2, 2022
@wey-gu wey-gu mentioned this pull request Dec 3, 2022
Closed
codesigner pushed a commit to codesigner/nebula that referenced this pull request Dec 5, 2022
@cangfengzhs @codesigner
add new es client (vesoft-inc#4970)
c6ff15d 
* add new es client

* fix mem leak

* address some comment
@cangfengzhs cangfengzhs mentioned this pull request Dec 8, 2022
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@critical27 critical27 critical27 approved these changes

@panda-sheep panda-sheep panda-sheep approved these changes

@pengweisong pengweisong Awaiting requested review from pengweisong

@SuperYoko SuperYoko Awaiting requested review from SuperYoko

@liwenhui-soul liwenhui-soul Awaiting requested review from liwenhui-soul

Assignees
No one assigned
Labels
ready for review ready-for-testing PR: ready for the CI test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cangfengzhs @critical27 @panda-sheep