Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add max connections flag #5309

Merged
merged 1 commit into from
Feb 3, 2023
Merged

add max connections flag #5309

merged 1 commit into from
Feb 3, 2023

Conversation

jievince
Copy link
Contributor

@jievince jievince commented Feb 3, 2023

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.）
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@jievince jievince requested a review from a team as a code owner February 3, 2023 07:30
@jievince jievince added ready-for-testing PR: ready for the CI test doc affected PR: improvements or additions to documentation labels Feb 3, 2023
dutor
dutor approved these changes Feb 3, 2023
View reviewed changes
Copy link
Contributor

@dutor dutor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job

@dutor dutor merged commit 7470a4a into vesoft-inc:master Feb 3, 2023
@wey-gu wey-gu mentioned this pull request Feb 4, 2023
Closed
@jievince jievince deleted the thrift-max-requests branch February 5, 2023 10:43
@abby-cyber
Copy link
Contributor

vesoft-inc/nebula-docs-cn#2687

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dutor dutor dutor approved these changes

@Shylock-Hg Shylock-Hg Shylock-Hg approved these changes

@HarrisChu HarrisChu Awaiting requested review from HarrisChu

@xiajingchun xiajingchun Awaiting requested review from xiajingchun

@yixinglu yixinglu Awaiting requested review from yixinglu

Assignees
No one assigned
Labels
doc affected PR: improvements or additions to documentation ready-for-testing PR: ready for the CI test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jievince @abby-cyber @dutor @Shylock-Hg