Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the crash when lookup parameter expression eval in storage #5336

Merged
merged 3 commits into from
Feb 14, 2023
Merged

Fix the crash when lookup parameter expression eval in storage #5336

merged 3 commits into from
Feb 14, 2023

Conversation

czpmango
Copy link
Contributor

@czpmango czpmango commented Feb 13, 2023 •
edited
Loading

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

https://discuss.nebula-graph.com.cn/t/topic/12100/21
#5350

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.）
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

@czpmango czpmango added ready-for-testing PR: ready for the CI test ready for review labels Feb 13, 2023
yixinglu
yixinglu previously approved these changes Feb 13, 2023
View reviewed changes
@Sophie-Xie Sophie-Xie changed the title Fix lookup parameter expression eval in storage Fix the crash when lookup parameter expression eval in storage Feb 13, 2023
@Sophie-Xie Sophie-Xie added affects/master PR/issue: this bug affects master version. affects/v3.4 PR/issue: this bug affects v3.4.x version and removed affects/master PR/issue: this bug affects master version. labels Feb 13, 2023
@yixinglu yixinglu merged commit c20467f into vesoft-inc:master Feb 14, 2023
@jinyingsunny jinyingsunny mentioned this pull request Feb 17, 2023
Closed
@wey-gu wey-gu mentioned this pull request Feb 18, 2023
Closed
Sophie-Xie pushed a commit that referenced this pull request Mar 4, 2023
@czpmango @Sophie-Xie
Fix the crash when lookup parameter expression eval in storage #5336
9fcbe5b
Sophie-Xie pushed a commit that referenced this pull request Mar 6, 2023
@czpmango @Sophie-Xie
Fix the crash when lookup parameter expression eval in storage (#5336)
37b25cb
Sophie-Xie added a commit that referenced this pull request Mar 6, 2023
@Sophie-Xie @czpmango
Cherry pick v3.4.1 （from release 3.4.0 to 03.05) (#5387)
a6dc673 
* Fix the crash when lookup parameter expression eval in storage (#5336)

* Small fix for parameter tck (#5371)

* Fix crash of list related functions (#5383)

* fix coflicts

* fix coflicts

* fix tck

---------

Co-authored-by: kyle.cao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aiee Aiee Aiee approved these changes

@jievince jievince jievince approved these changes

@yixinglu yixinglu yixinglu left review comments

Assignees
No one assigned
Labels
affects/v3.4 PR/issue: this bug affects v3.4.x version already-picked-3.4 auto-sync cherry-pick-v3.4 ready for review ready-for-testing PR: ready for the CI test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@czpmango @yixinglu @Aiee @jievince @Sophie-Xie