Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix allpath memory tracker #5640

Merged

Conversation

nevermore3
Copy link
Contributor

@nevermore3 nevermore3 commented Jul 17, 2023

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

close https://github.com/vesoft-inc/nebula-ent/issues/2906

Description:

replace collect with collectAll, the returned Future will become completed when all input futures have become completed
avoid threads continue to run After the query exits under abnormal circumstances(OOM)

image

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@nevermore3 nevermore3 force-pushed the fix_path_memory_tacker_again branch from 1e21eb4 to 47538ed Compare July 17, 2023 01:59
@Sophie-Xie Sophie-Xie merged commit 8765f55 into vesoft-inc:master Jul 17, 2023
3 of 4 checks passed
Sophie-Xie pushed a commit that referenced this pull request Jul 20, 2023
fix allpath memory traker
Sophie-Xie added a commit that referenced this pull request Jul 20, 2023
* fix traverse build path memory tracker (#5619)

* Optimize the write performance when host is down (#5571)

* Optimize the write performance when host is down

* fix the comments

---------

Co-authored-by: Sophie <[email protected]>

* Fix too many logs print when listing sessions (#5618)

* Set min_level_for_custom_filter as 0 by default to delete expired d… (#5622)

Reset min_level_for_custom_filter as 0 by default to delete expired data during compaction

* Revert "Revert "Change ccache to sccache"" (#5623)

* Revert "Revert "Change ccache to sccache" (#5613)"

This reverts commit 08a5d90.

* Update pull_request.yml

* Revert  "Change ccache to sccache" (#5627)

Revert "Revert "Revert "Change ccache to sccache"" (#5623)"

This reverts commit c1b433d.

* fix all path memory tracker (#5621)

* fix all path memory tracker

* fix error

* Update pull_request.yml

enable sccache debug log

* Update pull_request.yml

add ninja -v

* Update pull_request.yml

* Update pull_request.yml

* Update pull_request.yml

* Update pull_request.yml

---------

Co-authored-by: George <[email protected]>
Co-authored-by: Sophie <[email protected]>

* Fix edge all predicate embedding when generating path (#5631)

* Fix edge all predicate embedding when generate path

* fmt

* Enhancement/eliminate invalid filter (#5634)

* Fix crash double free of expr.

* Change issue id.

* Elimintate invalid property filter.

* support find circular (#5636)

Co-authored-by: Sophie <[email protected]>

* fix allpath memory tracker (#5640)

fix allpath memory traker

* fix_delete_validate (#5645)

add test case

---------

Co-authored-by: jimingquan <[email protected]>
Co-authored-by: Ryan <[email protected]>
Co-authored-by: Songqing Zhang <[email protected]>
Co-authored-by: George <[email protected]>
Co-authored-by: kyle.cao <[email protected]>
Co-authored-by: shylock <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants