fix the bug that index scan rule chooses a wrong geo index #5922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jievince
force-pushed
the
fix-geo-index-crash
branch
from
b12a1d3
to
8985380
Compare
jievince
requested review from
MuYiYong,
Salieri-004,
yixinglu,
codesigner,
nevermore3,
Aiee and
czpmango
and removed request for
Salieri-004 and
MuYiYong
Aiee
approved these changes
Aug 14, 2024
nevermore3
approved these changes
Aug 14, 2024
cfwl100
pushed a commit
to cfwl100/nebula
that referenced
this pull request
Sep 2, 2024
* 'master' of https://github.com/cfwl100/nebula: Enabled CodeQL scanning fix the bug that index scan rule chooses a wrong geo index (vesoft-inc#5922) snapshot manager add ssl config
cfwl100
added a commit
to cfwl100/nebula
that referenced
this pull request
Sep 2, 2024
* 'master' of https://github.com/cfwl100/nebula: Enabled CodeQL scanning fix the bug that index scan rule chooses a wrong geo index (vesoft-inc#5922) snapshot manager add ssl config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
Fix #5919
Description:
When geo indexes and other indexes are on a tag/edge type, the services will crash because it may wrongly choose a non-geo index for a geo-related query.
How do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Checklist:
Tests:
Affects:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: