Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable LTO by default once it no longer breaks a bunch of platforms #33

Closed
alexrp opened this issue Jul 18, 2021 · 3 comments
Closed

Enable LTO by default once it no longer breaks a bunch of platforms #33

alexrp opened this issue Jul 18, 2021 · 3 comments
Labels
area: tasks Issues related to MSBuild tasks.
Milestone
v5.0

Comments

@alexrp
Copy link
Member

alexrp commented Jul 18, 2021 •
edited
Loading

It blocks win-x86 completely (see ziglang/zig#8531) and breaks various other platform/language combinations.
@alexrp alexrp added type: feature state: blocked Issues that are blocked on some other issue or work. area: tasks Issues related to MSBuild tasks. labels Jul 18, 2021
@alexrp alexrp added this to the v4.0 milestone Jul 18, 2021
@alexrp alexrp self-assigned this Jul 18, 2021
@alexrp
Copy link
Member Author

alexrp commented Jul 23, 2021

Note that LTO is now user-configurable and off by default: 4deb807

@alexrp alexrp changed the title Enable LTO once it no longer breaks a bunch of platforms Enable LTO by default once it no longer breaks a bunch of platforms Jul 25, 2021
@alexrp alexrp modified the milestones: v4.0, v5.0 Sep 7, 2021
@alexrp
Copy link
Member Author

alexrp commented Aug 4, 2023 •
edited
Loading

Should check the current state of this in Zig 0.11.0. Seems to be working.

@alexrp alexrp modified the milestones: v5.0, v4.1, v4.0 Aug 4, 2023
alexrp added a commit that referenced this issue Aug 4, 2023
@alexrp
Enable LTO by default.
311761e 
Closes #33.
@alexrp
Copy link
Member Author

alexrp commented Aug 4, 2023 •
edited
Loading

Still some breakage on some platforms; pushing to v5.0.

ziglang/zig#15958

@alexrp alexrp modified the milestones: v4.0, v5.0 Aug 4, 2023
@alexrp alexrp modified the milestones: v5.0, Future Jan 1, 2024
@alexrp alexrp closed this as completed in 9eacca2 Apr 20, 2024
@alexrp alexrp removed their assignment Apr 20, 2024
@alexrp alexrp removed the state: blocked Issues that are blocked on some other issue or work. label Apr 20, 2024
@alexrp alexrp modified the milestones: Future, v5.0 Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: tasks Issues related to MSBuild tasks.
Milestone
v5.0
Development

No branches or pull requests
1 participant
@alexrp