-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for WHATWG URL #17
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
👋 phase/new
Post is being triaged automatically
🤞 phase/open
Post is being triaged manually
and removed
👋 phase/new
Post is being triaged automatically
labels
Jun 10, 2021
wooorm
reviewed
Jun 10, 2021
aduh95
commented
Jun 10, 2021
wooorm
reviewed
Jun 10, 2021
wooorm
approved these changes
Jun 10, 2021
ChristianMurphy
approved these changes
Jun 10, 2021
Murderlon
approved these changes
Jun 10, 2021
remcohaszing
approved these changes
Jun 10, 2021
This comment has been minimized.
This comment has been minimized.
wooorm
added
💪 phase/solved
Post is done
🗄 area/interface
This affects the public interface
🦋 type/enhancement
This is great to have
🧒 semver/minor
This is backwards-compatible change
labels
Jun 11, 2021
wooorm
added a commit
that referenced
this pull request
Jun 11, 2021
Thanks, released! |
aduh95
added a commit
to targos/node
that referenced
this pull request
Jun 11, 2021
wooorm
added a commit
to vfile/vfile
that referenced
this pull request
Aug 15, 2021
This adds support for setting file URLs (WHATWG URL objects that start with `file:`) as `path`, which will convert them to an actual file path. This also allows URL objects in the options and on their own as an argument. Related to vfile/to-vfile#17
5 tasks
wooorm
added a commit
to vfile/vfile
that referenced
this pull request
Aug 15, 2021
This adds support for setting file URLs (WHATWG URL objects that start with `file:`) as `path`, which will convert them to an actual file path. This also allows URL objects in the options and on their own as an argument. Related to vfile/to-vfile#17
wooorm
added a commit
to vfile/vfile
that referenced
this pull request
Aug 19, 2021
Closes GH-63. Related to: vfile/to-vfile#17. Reviewed-by: Remco Haszing <[email protected]> Reviewed-by: Christian Murphy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🗄 area/interface
This affects the public interface
💪 phase/solved
Post is done
🧒 semver/minor
This is backwards-compatible change
🦋 type/enhancement
This is great to have
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial checklist
Description of changes
Fixes: #16