Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare PR for adaption on CCombo #58

Closed
akoch-yatta opened this issue May 17, 2024 · 1 comment
Closed

Prepare PR for adaption on CCombo #58

akoch-yatta opened this issue May 17, 2024 · 1 comment
Assignees
@ShahzaibIbrahim
Labels
Enhancement A Request for an Enhancement of an Existing Feature HiDPI A HiDPI-Related Issue or Feature SWT Issue for SWT

Comments

@akoch-yatta
Copy link

akoch-yatta commented May 17, 2024 •
edited
Loading

Create PR for CCombo. Conditions are:

Minimal invasive: All changes should be checked under this condition. Prevent quality refactoring as much as possible or submit them in advance in a separate PR
Tests: Add tests to verify the behaviour when the zoom changes

Note: Investigate, on which PR it makes most sense to base it on
@akoch-yatta akoch-yatta added SWT Issue for SWT HiDPI A HiDPI-Related Issue or Feature Enhancement A Request for an Enhancement of an Existing Feature labels May 17, 2024
@akoch-yatta akoch-yatta mentioned this issue Jun 24, 2024
Closed
10 tasks
@ShahzaibIbrahim
Copy link

Merged in eclipse-platform/eclipse.platform.swt#1284

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ShahzaibIbrahim ShahzaibIbrahim

Labels
Enhancement A Request for an Enhancement of an Existing Feature HiDPI A HiDPI-Related Issue or Feature SWT Issue for SWT
Projects
Eclipse
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ShahzaibIbrahim @akoch-yatta