-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scaling combo text according to zoom level #1284
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ShahzaibIbrahim the code looks OK but I tested and found out that the elements of the list are displayed far away from the combo.
Can you please look into that?
@fedejeanne I have fixed the issue. Could you please check it again in both cases? (100 -> 200) and (200 ->100) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested it and it looks fine. I just have a question regarding the moving of the class outside of the package internal
...org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/custom/CommonWidgetsDPIChangeHandlers.java
Outdated
Show resolved
Hide resolved
853e7a0
to
2e1e202
Compare
...g.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/internal/CommonWidgetsDPIChangeHandlers.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT Custom Widgets/common/org/eclipse/swt/custom/CCombo.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, the changes look good. The comments of Andreas and me should be rather easy to address.
bundles/org.eclipse.swt/Eclipse SWT Custom Widgets/common/org/eclipse/swt/custom/CCombo.java
Outdated
Show resolved
Hide resolved
...g.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/internal/CommonWidgetsDPIChangeHandlers.java
Outdated
Show resolved
Hide resolved
@fedejeanne please check if you still request changes or may drop your change request |
bundles/org.eclipse.swt/Eclipse SWT Custom Widgets/common/org/eclipse/swt/custom/CCombo.java
Outdated
Show resolved
Hide resolved
Registering the comboDpiChange handler and applying change manually to text, image and arrow and popup
Registering the comboDpiChange handler and applying change manually to
text, image and arrow
Contributes to #62 and #127
HOW TO TEST (Windows only!)
CustomControlExample
with the following VM ArgumentsEXPECTED BEHAVIOUR
Combo list, text and arrow should be properly scaled.