Added functionality to ignore multiple ports #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@christopherhelf Thanks for the PR! I'll have a look in the next few days. |
|
You're welcome, I thought it would be a good addition. I'm new to Go so there might be better ways to do this?, but it worked fine in my tests. |
| @@ -28,12 +28,21 @@ func (s Service) AddressAndPort() string { | |||
|
|
|||
| var timeout = flag.Int64("timeout", 60, "time to wait for all services to be up (seconds)") | |||
| var httpPort = flag.Int("httpport", 0, "wait for an http request if target port is given port") | |||
| var ignorePort = flag.Int("ignoreport", 0, "don't wait for services on this port to be up") | |||
| var _ignorePort = flag.String("ignoreport", "", "don't wait for services on these ports to be up (separated by comma)") | |||
|
@christopherhelf The basic idea is good, I added a few comments to the code on things you could improve. Just so you know, Docker links are going to disappear and we haven't looked into how |
|
Closed due to lack of activity |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added functionality to ignore multiple ports via the ignoreports flag, multiple ports have to be separated by comma, e.g.