Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCS-2887: Support command line args for training scripts #3617

Merged
merged 2 commits into from
Oct 24, 2024

Conversation

npentrel
Copy link
Collaborator

@npentrel npentrel commented Oct 23, 2024

@viambot viambot added the safe to build This pull request is marked safe to build from a trusted zone label Oct 23, 2024
Copy link
Member

@vpandiarajan20 vpandiarajan20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small fix needed, but looks great, thank you!

Copy link
Collaborator

@JessamyT JessamyT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from docs perspective % nits and SME approval

docs/how-tos/create-custom-training-scripts.md Outdated Show resolved Hide resolved
docs/how-tos/create-custom-training-scripts.md Outdated Show resolved Hide resolved
Co-authored-by: JessamyT <[email protected]>
Co-authored-by: Vignesh P <[email protected]>
@viambot
Copy link
Member

viambot commented Oct 24, 2024

You can view a rendered version of the docs from this PR at https://docs-test.viam.dev/3617

@npentrel npentrel merged commit 941712d into viamrobotics:main Oct 24, 2024
9 checks passed
@npentrel npentrel deleted the DOCS-2887 branch October 24, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to build This pull request is marked safe to build from a trusted zone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants