Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the stable stdx-allocator DUB package #43

Merged
merged 1 commit into from
Dec 4, 2017

Conversation

wilzbach
Copy link
Member

As discussed before, stdx-allocator is a frozen version of std.experimental.allocator to avoid the frequent breakages.

See also: dlang-community/discussions#27

@wilzbach
Copy link
Member Author

wilzbach commented Dec 1, 2017

Hmm this doesn't seem to work with DMD 2.071 (and thus LDC 1.1):

image

While the non-existent Ternary problem and a couple of other issues with an older Phobos can be fixed easily, one then still runs into safety issues with 2.071.2:

image

I don't really fancy wasting time looking into these and would only do so if dropping support for 2.071.1 isn't an option. I just pushed dlang-community/stdx-allocator@d06e4f2, which allows building stdx-allocator with 2.072.2.

Let me know how you would like to proceed.

@s-ludwig
Copy link
Member

s-ludwig commented Dec 3, 2017

I've opened #45 to drop 2.071 support.

@wilzbach
Copy link
Member Author

wilzbach commented Dec 3, 2017

I've opened #45 to drop 2.071 support.

Thanks! (Rebased this PR)

@wilzbach
Copy link
Member Author

wilzbach commented Dec 4, 2017

Everything passing 🎉

image

@s-ludwig s-ludwig merged commit c9aaf0c into vibe-d:master Dec 4, 2017
@wilzbach wilzbach deleted the stdx-allocator branch December 4, 2017 21:49
@wilzbach
Copy link
Member Author

wilzbach commented Dec 4, 2017

Tagged this as v1.4.0-alpha.1, s.t. it can be used by Vibe.d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants