Remove 2.071.x compatibility code #1998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilzbach
approved these changes
Dec 11, 2017
|
Meson failing again? |
|
May be an issue with the tag_version script, since it started to fail in 38d5da2 with: I'll have a look. |
|
Hm, it's actually still mesonbuild/meson#2719 and there is just a new Meson version that still has the issue. |
wilzbach
reviewed
Dec 12, 2017
| @@ -52,7 +52,7 @@ matrix: | |||
|
|
|||
| before_install: | |||
| - pyenv global system 3.5 | |||
| - pip3 install 'meson>=0.42,!=0.43' | |||
| - pip3 install 'meson>=0.42,!=0.43,!=0.44' | |||
There was a problem hiding this comment.
pip install 'meson==0.42' would be a lot safer ...
There was a problem hiding this comment.
That's true, I was also thinking about that. I guess the idea behind that was to not forget about this issue and enforce getting back to the latest release at some point. To me it would be fine to keep it like this for another version, but then I'd also rather like to go with ==0.42 to avoid this becoming a regular distraction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.