Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safe discover of redis version #506

Merged
merged 1 commit into from
Feb 9, 2014
Merged

Safe discover of redis version #506

merged 1 commit into from
Feb 9, 2014

Conversation

fabsi88
Copy link
Contributor

@fabsi88 fabsi88 commented Feb 8, 2014

My original pull request worked well for redis version 2.6.12 on Windows 8.1 (my test system) but does not work on my production site (redis version 2.2.12 and ubuntu 12.04.4 LTS). On Windows 8.1 and Redis 2.6.12 lines[0] equals "#Server" (like the doc - http://redis.io/commands/info) but on production site lines[0] contains the version.
So I think this is the better solution for retrieving the redis version independent of OS-/Redis-Version.

@s-ludwig
Copy link
Member

s-ludwig commented Feb 9, 2014

OK, good to know. Does the 2.2 server have sections at all (i.e. "Clients", "Memory", ...)? Or does it simply mix everything together as one list?

s-ludwig added a commit that referenced this pull request Feb 9, 2014
Safe discover of redis version
@s-ludwig s-ludwig merged commit df3ec55 into vibe-d:master Feb 9, 2014
@fabsi88
Copy link
Contributor Author

fabsi88 commented Feb 9, 2014

Thanks for merge. No, there are no sections. Just a list of all properties. Refering to the release notes of redis (https://raw.github.com/antirez/redis/2.6/00-RELEASENOTES) sections and empty lines are a new feature in 2.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants