-
-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] Handy bookmarklet #22
Comments
I think it is doable, I've done a lot of bookmarklets in the past. I'll have to check if I'm not missing any semicolons, and I have to strip all the comments, and URL encode it. I just haven't done it because it is not something that is easy to explain to the average user, lots of things to get wrong. For example I expect a lot of people wondering why this doesn't work I use this chrome extension to create bookmarklets (It also doesn't like comments.) |
The usability is certainly an argument... Making a GitHub Page with a drag'n'droppable Bookmarklet link seems a bit overkill as well. It doesn't work in Markdown sadly: <a href="javascript:void((function(){alert("Hello GitHub!")})());">Drag Me! |
I could make a github page using rollup and a node script, I’ll make some experiments when I have time.
But I also dislike the idea of encouraging people to run minified code on their browsers, because it could be a security issue.
I was very deliberate in making the code verbose with comments and without any external library.
I know the average user doesn’t know how to inspect code, but at the same time the code is publicly available, so anyone can audit it and know for sure I’m not doing anything sketchy.
…Sent from my iPhone
On Nov 4, 2019, at 5:09 PM, NullDev (Chris) ***@***.***> wrote:
The usability is certainly an argument... Making a GitHub Page with a drag'n'droppable Bookmarklet link seems a bit overkill as well. It doesn't work in Markdown sadly:
<a href="javascript:void((function(){alert("Hello GitHub!")})());">Drag Me!
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Any updates on this? |
Just an idea: Making a handy bookmarklet for it?
Tried to minify the code and paste it like
javascript:(function(){...
as bookmarklet.PopUp opens fine. This line however makes the whole page go blank/white with the text "Looking good!". Removing the line seems to work. getting the AuthToken, AuthorID and ChannelID appears to work as well, but deleting does't. I guess the bookmarklet doesn't have access to the same context in which devtools is running, but haven't had time to debug in depth
The text was updated successfully, but these errors were encountered: