Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Handy bookmarklet #22

Closed
NullDev opened this issue Nov 2, 2019 · 5 comments
Closed

[Enhancement] Handy bookmarklet #22

NullDev opened this issue Nov 2, 2019 · 5 comments
Labels

Comments

@NullDev
Copy link

NullDev commented Nov 2, 2019

Just an idea: Making a handy bookmarklet for it?
Tried to minify the code and paste it like javascript:(function(){... as bookmarklet.
PopUp opens fine. This line however makes the whole page go blank/white with the text "Looking good!". Removing the line seems to work. getting the AuthToken, AuthorID and ChannelID appears to work as well, but deleting does't. I guess the bookmarklet doesn't have access to the same context in which devtools is running, but haven't had time to debug in depth

@victornpb victornpb added the feature-enhancement New feature or request label Nov 4, 2019
@victornpb
Copy link
Owner

I think it is doable, I've done a lot of bookmarklets in the past. I'll have to check if I'm not missing any semicolons, and I have to strip all the comments, and URL encode it.

I just haven't done it because it is not something that is easy to explain to the average user, lots of things to get wrong. For example I expect a lot of people wondering why this doesn't work https://javascript:(func...

I use this chrome extension to create bookmarklets (It also doesn't like comments.)
https://chrome.google.com/webstore/detail/bookmarklet-ide/peebnjhlifoemfpcffdlbcdppmikglek

@NullDev
Copy link
Author

NullDev commented Nov 4, 2019

The usability is certainly an argument... Making a GitHub Page with a drag'n'droppable Bookmarklet link seems a bit overkill as well. It doesn't work in Markdown sadly:

<a href="javascript:void((function(){alert("Hello GitHub!")})());">Drag Me!

@victornpb
Copy link
Owner

victornpb commented Nov 4, 2019 via email

@itzTheMeow
Copy link

Any updates on this?

@victornpb
Copy link
Owner

Any updates on this?

Yes! sorry for taking so long, but I made it available as a installable user-script.
Take a look at the new readme in the front page, should be much easier to non-techinicall ppl and more convenient to use.

Any feedback is appreciated.

Screen Shot 2020-07-05 at 1 25 57 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants