Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

user script without a popup #89

Merged
merged 1 commit into from
Jul 5, 2020
Merged

user script without a popup #89

merged 1 commit into from
Jul 5, 2020

Conversation

victornpb
Copy link
Owner

@victornpb victornpb commented Jul 5, 2020

Screen Shot 2020-07-05 at 1 25 57 AM

Implemented a version with does not use a Popup window, but instead adds button to the discord toolbar that opens a popover/sidebar inside the discord UI.

This has a few advantages being it should fix issues with popups being blocked #71 #70 #45

Solves the requests for bookmarklets #22 #19 because it is compatible with user scripts, so you can install it with Tampermonkey and have it permanently there.

It is possible to run it from the Electron app and not only inside the web app #68.

It should reduce memory usage by not creating another windows with another document.


This change is Reviewable

@victornpb victornpb merged commit baba293 into master Jul 5, 2020
@victornpb victornpb changed the title created user script wuthout a popup user script without a popup Jul 5, 2020
@victornpb victornpb deleted the no-popup-implementation branch July 5, 2020 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant