forked from easybuilders/easybuild-framework
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rename filetools.readlink to filetools.resolve_path, use os.path.realpath, enhance test for symlink & resolve_path #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…path, enhance test for symlink & resolve_path
victorusu
approved these changes
Mar 24, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
victorusu
pushed a commit
that referenced
this pull request
Jul 10, 2017
enhance test for copy_file to check for gracefully handling copying file to itself
victorusu
pushed a commit
that referenced
this pull request
Jan 30, 2019
--container-tmpdir fix + test
victorusu
pushed a commit
that referenced
this pull request
Jan 30, 2019
sync with develop + restore use of 'build_option' to determine container type
victorusu
pushed a commit
that referenced
this pull request
Jan 30, 2019
prefer templates with shortest 'key' in case of duplicate template values in EasyConfig.dump
victorusu
pushed a commit
that referenced
this pull request
Jan 30, 2019
use https in source_urls in gzip test easyconfigs Thanks @boegel
victorusu
pushed a commit
that referenced
this pull request
Jan 23, 2020
enhance test for --new-pr to make sure that repo is cloned from working copy rather than copied (so unstaged files are ignored)
victorusu
pushed a commit
that referenced
this pull request
Jan 23, 2020
add tests for curr_module_paths + check_module_path
victorusu
pushed a commit
that referenced
this pull request
Apr 8, 2020
minor fix + enhanced test for skipped extensions
victorusu
pushed a commit
that referenced
this pull request
Feb 2, 2021
enhance test to check that there's no 'javaminver' template if there is no minor version
victorusu
pushed a commit
that referenced
this pull request
Feb 2, 2021
also consider builddependencies when config passed to template_constant_dict is not an EasyConfig instance yet + add comments to clarify what's going on
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@victorusu for easybuilders#2110, let's finish it :)